Skip to content

Add partner integration specs: Bankr, Gina, Robonet#8

Merged
AlexanderLawson17 merged 1 commit into
mainfrom
docs/partner-specs
Apr 2, 2026
Merged

Add partner integration specs: Bankr, Gina, Robonet#8
AlexanderLawson17 merged 1 commit into
mainfrom
docs/partner-specs

Conversation

@AlexanderLawson17

Copy link
Copy Markdown
Owner

Summary

Technical integration specifications for 3 ecosystem partners, designed to be sent directly to their engineering teams as outreach artifacts.

Changes

  • docs/integrations/bankr-integration-spec.md — Discovery layer enrichment with trust scores, API contract, feedback loop, business model
  • docs/integrations/gina-failure-signal-mapping.md — Maps 4 failure modes to scoring signals, data partnership terms, integration architecture
  • docs/integrations/robonet-mcp-composition.md — MCP server composition guide with Claude Code/Cursor configs, agent flow examples

Plan Reference

Plan file: ~/.claude/plans/harmonic-sprouting-melody.md — Agent B workstream

Test Plan

  • Each spec is >2KB and self-contained
  • API references match actual Revettr v1/score contract
  • Code samples are syntactically valid Python
  • ASCII diagrams render correctly in GitHub markdown

Generated with Claude Code

- bankr-integration-spec.md: Discovery layer enrichment with trust scores
- gina-failure-signal-mapping.md: Failure mode to scoring signal mapping
- robonet-mcp-composition.md: MCP server composition guide

Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>

@chatgpt-codex-connector chatgpt-codex-connector Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: 064e8dab4c

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

"mcpServers": {
"revettr": {
"type": "streamable-http",
"url": "https://mcp.revettr.com/sse",

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

P1 Badge Use the published Revettr MCP URL in remote config

The Streamable HTTP example config points Revettr to https://mcp.revettr.com/sse, but this repository’s published MCP server manifest advertises https://revettr.com/mcp (server.json remotes URL). If partners copy this snippet as-is, MCP client registration will target the wrong endpoint and the risk-check tool chain will fail before deployment decisions.

Useful? React with 👍 / 👎.

elif trade_size_usdc >= 100:
return 40
else:
return 20 # Micro-transactions: minimal gating

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

P2 Badge Align micro-transaction threshold with documented policy

This branch returns 20 for trades under $100, but the “Dynamic Threshold by Trade Size” table later in the same document says < $100 should require a minimum score of 40. That inconsistency causes materially different gating behavior depending on whether an integrator follows the code sample or the policy table, and it weakens the documented risk posture for small trades.

Useful? React with 👍 / 👎.

Comment on lines +264 to +268
result = client.score(
wallet_address=counterparty_wallet,
domain=counterparty_domain,
chain=chain,
)

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

P2 Badge Avoid synchronous scoring inside async pre-check

pre_execution_check is async, but it calls client.score(...), and the SDK method performs synchronous HTTP (httpx.Client.post in revettr/client.py). In an asyncio-based Gina pipeline, this blocks the event loop during network I/O, reducing concurrency and increasing latency for unrelated tasks; the sample should use an async call path or run the sync call in a worker thread.

Useful? React with 👍 / 👎.

@AlexanderLawson17 AlexanderLawson17 merged commit 012ec62 into main Apr 2, 2026
0 of 3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant